Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep in-files search dialog open, closes #1663, by @harshad1 #1689

Merged
merged 7 commits into from
May 21, 2022
Merged

Keep in-files search dialog open, closes #1663, by @harshad1 #1689

merged 7 commits into from
May 21, 2022
+15 −4

Conversation

harshad1
Copy link
Collaborator

This PR adds the following features to the in-files search results:

  1. The dialog will stay open when an item is clicked. Can return to main via back or recent apps and open another file.
  2. The file names (group names) have been made bold
  3. Long clicking the file name will take you to the top of the file

@gsantner gsantner added this to the Markor v2.10 milestone May 14, 2022
@gsantner gsantner force-pushed the master branch 4 times, most recently from 8bbdc13 to b9c45c3 Compare May 15, 2022 02:17
gsantner
gsantner approved these changes May 21, 2022
View reviewed changes
Copy link
Owner

@gsantner gsantner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks works good

remove the bold though..it was just everything bold - too much. But generally the dialog and it's contents could be a bit face-lifted wording improved / better styled 😄 .

@gsantner gsantner changed the title Keep in-files search dialog open Keep in-files search dialog open, closes #1663 May 21, 2022
@gsantner gsantner changed the title Keep in-files search dialog open, closes #1663 Keep in-files search dialog open, closes #1663, by @harshad1 May 21, 2022
@gsantner gsantner merged commit 79327f4 into gsantner:master May 21, 2022
@gsantner gsantner mentioned this pull request Jul 16, 2022
Merged
@harshad1 harshad1 deleted the keep_search_open branch May 10, 2023 14:38
Adirlearn-dev12
Adirlearn-dev12 reviewed May 1, 2024
View reviewed changes
Copy link

@Adirlearn-dev12 Adirlearn-dev12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me sorprendió la app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Adirlearn-dev12 Adirlearn-dev12 Adirlearn-dev12 left review comments

@gsantner gsantner gsantner approved these changes

Assignees

@harshad1 harshad1

Labels
None yet
Projects
None yet
Milestone
Markor v2.10
Development

Successfully merging this pull request may close these issues.
3 participants
@harshad1 @gsantner @Adirlearn-dev12